| Age | Commit message (Collapse) | Author |
|
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Thanks-to: Arisu Tachibana <alicef@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
_cmake_minreqver-check may be called from any phase, so <file> path must be
absolute. As a quick fix, push the path mangling into the output function
_cmake_minreqver-info which (currently) is only called from cmake_prepare.
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Move "CMake 4 detected" message around, with bigger file listings,
and logically, it is better placed at the end, before the upstream
policy changes research link.
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Print "QA Notice" only on first (highest priority) warning, but still show
the relevant message.
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
- New variable CMAKE_ECM_MODE (values: auto,true,false)
Also use instead of _ECM_ECLASS check in cmake_src_configure
- _cmake_minreqver-check():
Results are stored in new _CMAKE_MINREQVER_CMAKE316 array.
- _cmake_minreqver-info():
Dump _CMAKE_MINREQVER_CMAKE316 array as eqawarn
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
- _cmake_minreqver-check():
Results are stored in new _CMAKE_MINREQVER_CMAKE310 array.
- _cmake_minreqver-info():
Dump _CMAKE_MINREQVER_CMAKE310 array as eqawarn
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
If QA checks are skipped, then it is counterproductive to hide
resulting errors.
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
- Dump _CMAKE_MINREQVER_CMAKE305 array as eqawarn message
- CMake 4 workaround warning resharpening
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
- Prepare for future cmake_minimum_version checks
- Function now optionally takes one or two args:
<file>: runs all version checks over <file>
<file> <version>: only checks <version> against <file>
- _CMAKE_MINREQVER_UNSUPPORTED is gone
- _CMAKE_MINREQVER_CMAKE305 is empty (package "passed") or contains a list
of <file>:<version> tuples
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
See also:
https://cmake.org/cmake/help/latest/policy/CMP0094.html
Bug: https://bugs.gentoo.org/959154
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
As we already do for compiler -Werror.
Bug: https://bugs.gentoo.org/963830
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
This commit updates the CMAKE_WARN_UNUSED_CLI variable description to
accurately reflect the default value set to "yes".
The CMAKE_WARN_UNUSED_CLI default value was changed to "yes" in
cmake-utils.eclass in commit 3600c714eb86 ("cmake-utils.eclass: enable
CMAKE_WARN_UNUSED_CLI for EAPI 6"), but the description did not reflect
it. This description was later reused in the new cmake.eclass [1]
without reflecting the default value either.
Fixes: 9053737a4e16 ("cmake.eclass: New eclass, EAPI-7 only cleanup of cmake-utils") [1]
Signed-off-by: Petr Vaněk <arkamar@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Pass -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=OFF to avoid automagically
enabling LTO if the compiler supports it.
Note that unlike what we do w/ meson.eclass, we can't do some magic
with `tc-is-lto` here because CMake doesn't allow refining the parallelism
used. But that's fine.
This change still allows using LTO via *FLAGS which is what we tell
people to do.
Bug: https://bugs.gentoo.org/927157
Signed-off-by: Sam James <sam@gentoo.org>
|
|
... after 2025-11-01.
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Escape sequences are not allowed for `die`, use eerror instead.
Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
This is already expected in tree via virtx use.
$ qgrep 'virtx cmake_src_test' | wc -l
57
Bug: https://bugs.gentoo.org/961929
Closes: https://github.com/gentoo/gentoo/pull/40307
Signed-off-by: Alfred Wingate <parona@protonmail.com>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Split out what we need from cmake_src_prepare into new cmake_prepare().
cmake_src_prepare henceforth just calls default_src_prepare(),
then cmake_prepare(). This change was made for >=EAPI-8 only.
Bug: https://bugs.gentoo.org/853805
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Bug: https://bugs.gentoo.org/963428
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Otherwise the regex might pick up a query of the resulting version var, e.g.:
> if(CMAKE_MINIMUM_REQUIRED_VERSION VERSION_LESS 2.8.12)
Bug: https://bugs.gentoo.org/958923
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
See examples:
https://bugs.gentoo.org/953075
https://bugs.gentoo.org/957670
https://bugs.gentoo.org/957671
https://bugs.gentoo.org/957803
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Thanks-to: Ionen Wolkens <ionen@gentoo.org>
Closes: https://bugs.gentoo.org/957990
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
- _cmake_minverreq-lt(): New function for reusability of regex
- Optimise #1: Reuse existing loop over CMakeLists.txt files
- Optimise #2: If _CMAKE_MINREQVER_UNSUPPORTED is already set, then no
further run of _cmake_minverreq-lt is necessary since we currently throw
away the info on affected files
- Relegate "CMake 4 detected; ..." to be a non-QA Notice, it is just an
addendum
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Allows to split detection/eqawarn and applying cmakearg over different
phases.
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Otherwise sed may fail (as it can't find the files) on directories/files
with spaces in the path, as is the case in dev-build/cmake itself
where it'll die in src_prepare.
Signed-off-by: Sam James <sam@gentoo.org>
|
|
See also:
https://github.com/gentoo/kde/pull/1046#pullrequestreview-2897140501
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
50% less find
50% less grep
100% less cut
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
See also: https://github.com/gentoo/gentoo/pull/39544
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Bug: https://bugs.gentoo.org/945081
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
We don't want more than one version for the subsequent ver_test.
Besides, any follow-up cmake_minimum_required call will most likely
be conditional for some type of workarounds.
Thanks-to: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
As a quick fix, for now, don't error out on that.
> ERROR: media-gfx/darktable-5.0.1-r2::gentoo failed (configure phase):
> __eapi7_ver_compare: invalid version: 3.12..16
See also:
> LibRaw-cmake/CMakeLists.txt:cmake_minimum_required(VERSION 3.12..16)
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
-DCMAKE_POLICY_VERSION_MINIMUM=3.5
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
We need to ramp up detection of unsupported CMake build systems with
CMake 4. This will detect CMakeLists.txt files setting insufficient
cmake_minimum_required VERSION level even in project subdirectories,
putting out appropriate eqawarn message about the need to fix ${PN}.
That makes us not rely on tinderbox runs w/ unmasked cmake-4 slowly
being able to build everything up to leaf packages, and also helps
detect insufficient subproject minimums that could otherwise be masked
by USE flag choice.
Bug: https://bugs.gentoo.org/951350
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
This makes life easier for tinderboxes, but we should improve this in some future
EAPI.
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Bug: https://bugs.gentoo.org/926121
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Bug: https://bugs.gentoo.org/927160
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Modify cmake_src_prepare to qoute escape filenames
within the find search patterns
This resolves build issues with some EAPI 7 packages,
i.e. sys-fs/dislocker via catalyst
Bug: https://bugs.gentoo.org/811486
Signed-off-by: Nic Boet <nic@boet.cc>
Closes: https://github.com/gentoo/gentoo/pull/35125
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
|
|
Signed-off-by: Sam James <sam@gentoo.org>
|