diff options
| author | Sam James <sam@gentoo.org> | 2021-08-19 02:34:11 +0100 |
|---|---|---|
| committer | Sam James <sam@gentoo.org> | 2021-08-19 02:34:55 +0100 |
| commit | c6fc517e4bc5649e01af9d10a445338805a0cdfc (patch) | |
| tree | 18321c9f5820cbbadaf4221223e248523d31469e /metadata/install-qa-check.d | |
| parent | 6e3d2b93f454f86e5a838cf6dacd90c8e831afeb (diff) | |
| download | gentoo-c6fc517e4bc5649e01af9d10a445338805a0cdfc.tar.gz gentoo-c6fc517e4bc5649e01af9d10a445338805a0cdfc.tar.bz2 gentoo-c6fc517e4bc5649e01af9d10a445338805a0cdfc.zip | |
metadata/install-qa-check.d: skip some checks when TMPFILES_OPTIONAL is set
This is a good enough proxy for "this package has a complicated
relationship with tmpfiles" and replaces the hardcoded list of
exemptions.
Closes: https://bugs.gentoo.org/808781
Signed-off-by: Sam James <sam@gentoo.org>
Diffstat (limited to 'metadata/install-qa-check.d')
| -rw-r--r-- | metadata/install-qa-check.d/60tmpfiles-paths | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/metadata/install-qa-check.d/60tmpfiles-paths b/metadata/install-qa-check.d/60tmpfiles-paths index aa666dfb7ce5..1d46cab6ecc0 100644 --- a/metadata/install-qa-check.d/60tmpfiles-paths +++ b/metadata/install-qa-check.d/60tmpfiles-paths @@ -28,12 +28,12 @@ tmpfiles_check() { # We're now going to check for whether we install files to /usr/lib/tmpfiles.d without # inheriting the eclass (weak catch for ebuilds not calling tmpfiles_process in pkg_postinst) - # It's okay for some packages to do this because of circular dependencies and such - # See: https://archives.gentoo.org/gentoo-dev/message/0a96793036a4fdd9ac311a46950d7e7b - # TODO: Standardize some way of allowing ebuilds to opt-out of checks like this - local package=${CATEGORY}/${PN} - - if [[ ${package} == "sys-apps/systemd" || ${package} == "sys-libs/pam" ]] ; then + if [[ -n ${TMPFILES_OPTIONAL} ]] ; then + # While imperfect, using ${TMPFILES_OPTIONAL} is good enough to allow opting out + # for e.g. sys-apps/portage, sys-apps/systemd, sys-libs/pam, etc. We may want + # a better/more standardised way to opt out from QA checks in future. + # It's okay for some packages to do this because of circular dependencies and such + # See: https://archives.gentoo.org/gentoo-dev/message/0a96793036a4fdd9ac311a46950d7e7b return fi |