| Age | Commit message (Collapse) | Author |
|---|
|
As of 5.4_alpha_pre20251016, bash tests finally exit non-0 on failure. The
differences look harmless but need investigation and fixing.
See https://lists.gnu.org/archive/html/bug-bash/2025-10/msg00054.html.
Signed-off-by: Sam James <sam@gentoo.org>
|
|
This reverts commit 7ef5fa53b33a167be6da83c1bb003aabc3e9b7b4.
Noise in commit msg.
Signed-off-by: Sam James <sam@gentoo.org>
|
|
As of 5.4_alpha_pre20251016, bash tests finally exit non-0 on failure. The
differences look harmless but need investigation and fixing.
See https://lists.gnu.org/archive/html/bug-bash/2025-10/msg00054.html.
Signed-off-by: Sam James <sam@gentoo.org>
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
#
# On branch master
# Your branch is ahead of 'origin/master' by 1 commit.
# (use "git push" to publish your local commits)
#
# Changes to be committed:
# modified: Manifest
# copied: bash-9999.ebuild -> bash-5.4_alpha_pre20251016.ebuild
# modified: bash-9999.ebuild
#
# Changes not staged for commit:
# modified: ../../media-libs/coin/Manifest
# modified: ../../media-sound/rosegarden/Manifest
# modified: ../../sci-libs/djbfft/djbfft-0.76-r3.ebuild
#
# Untracked files:
# ../../media-libs/coin/coin-4.0.6.ebuild
# ../../media-sound/rosegarden/files/rosegarden-25.06-includes.patch
# ../../media-sound/rosegarden/rosegarden-25.06.ebuild
#
|
|
This commit introduces the following versions.
- 5.2_p37-r5
- 5.3_p3-r3
- bash-5.4_alpha_pre20250918-r2 (replacing -r1)
They improve the window title setting behaviour by using the ${param@P}
form of expansion to expand "\u@\h \W" as a prompt string. A notable
consequence of this is that, upon switching to the home directory, the
current working directory will be shown as the <tilde> character again.
The value of PROMPT_DIRTRIM is now respected. If this variable is unset,
the use of the \W prompt string escape will prevail, with the current
working directory typically being shown as its basename. If set to 0 or
greater, \w will be used instead, which may be trimmed. This means that
the title can be made to show the full path by setting PROMPT_DIRTRIM=0.
Also, whitelist xterm-ghostty for XTWINOPS support.
Signed-off-by: Kerin Millar <kfm@plushkava.net>
Signed-off-by: Sam James <sam@gentoo.org>
|
|
The bash ebuilds in SLOT 0 continue to diverge from one another in small
but irksome ways, which makes working on them a chore. As such, the main
purpose of this commit is to minimise the differences between them.
Beyond that, several other changes have been made. All of the changes
are described herewith.
As regards the matter of difference minimisation:
- order the patterns of the first case statement in a consistent way
- declare BASH_COMMIT within the scope of the first case statement
- always declare BASH_COMMIT (even if as a null string or dead code)
- remove a redundant ;; operator from the first case statement
- always acknowledge that BASH_COMMIT might be set
- declare S within the scope of the second case statement
- consistently mention that Chet advises against the use of byacc
In pkg_postinst(), incorporate a warning to the effect of the
"15-gentoo-bashrc-check.bash" file being safe to delete.
Restructure the pkg_postinst() code so as to make it easier to
incorporate additional, version-dependent, upgrade notices.
In pkg_postinst(), if the terminal is found to be more than 80 columns
wide, invoke the fmt(1) utility so as to reflow the upgrade notice(s).
Signed-off-by: Kerin Millar <kfm@plushkava.net>
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Link: https://bugs.gentoo.org/589444
Signed-off-by: Kerin Millar <kfm@plushkava.net>
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Without this, bash has:
> BASH_LOADABLES_PATH="/usr/local/lib/bash:/usr/lib/bash:/opt/local/lib/bash:/usr/pkg/lib/bash:/opt/pkg/lib/bash:."
That won't pick up even the place we install bash's own plugins to, let
alone where other packages might expect it. For the same reason, we can't
really just change it to /usr/lib/bash even if it might make sense to
given we don't have multilib bash.
Closes: https://bugs.gentoo.org/959687
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Signed-off-by: Sam James <sam@gentoo.org>
|
|
As regards the (commented) URIs referring to the available patchlevels:
- employ https:// rather than ftp://
- ensure that the URI request path consistently matches the version
- remove the URI altogether for snapshot ebuilds
Signed-off-by: Kerin Millar <kfm@plushkava.net>
Signed-off-by: Sam James <sam@gentoo.org>
|
|
This commit introduces 5.2_p37-r4 and bash-5.3_p3-r1, as well as
revising bash-9999. The effective changes are described herewith.
Install a new /etc/profile.d drop-in, named "00-prompt-command.sh". It
serves to initialise the PROMPT_COMMAND variable as early as is
conveniently possible, provided that bash is acting as a login shell.
Install a revision of the /etc/bash/bashrc file that refrains from
initialising the PROMPT_COMMAND variable, provided that bash is acting
as a login shell. Along with the aforementioned change, this amounts to
a simplified interpretation of GitHub PR #42626. Though not a common
practice, some /etc/profile.d drop-ins (such as vte-2.91.sh) need to be
able to manipulate PROMPT_COMMAND and had hitherto been stymied by
bashrc proceeding to unconditionally clobber it.
Finally, refrain from installing 15-gentoo-bashrc-check.bash to
/etc/bash/bashrc.d. At the time of its introduction, I recommended that
it should exist for no longer than a year. Its removal is overdue.
Reported-by: Krzesimir Nowak <knowak@microsoft.com>
Part-of: https://github.com/gentoo/gentoo/pull/42626
Closes: https://github.com/gentoo/gentoo/pull/42626
Signed-off-by: Kerin Millar <kfm@plushkava.net>
Signed-off-by: Sam James <sam@gentoo.org>
|
|
The top of FILESDIR has become a little unwieldy. In advance of
submitting a patch that will introduce yet more files to be tracked, I
thought that it would be a good opportunity to conduct a minor
re-organisation. To that end, this commit relocates the skeleton files
to a sub-directory.
Signed-off-by: Kerin Millar <kfm@plushkava.net>
Signed-off-by: Sam James <sam@gentoo.org>
|
|
I'm keywording it from the off because I've been running with this
for ages.
I've also dropped the removal of bundled readline -- we still use
the system copy, but the build was failing because builtins/ needs
rlconf.h for a few objects.
Signed-off-by: Sam James <sam@gentoo.org>
|
|
It shouldn't be needed these days, as e.g. alphas and such appear
on the GNU mirrors too.
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Essential for cross compile even for >=bash-5.3
Closes: https://bugs.gentoo.org/956318
Signed-off-by: Sungjoon Moon <sumoon@seoulsaram.org>
Part-of: https://github.com/gentoo/gentoo/pull/42240
Signed-off-by: James Le Cuirot <chewi@gentoo.org>
|
|
Signed-off-by: Sam James <sam@gentoo.org>
|
|
drop-ins
This sets the stage for eliminating 10-gentoo-color-r1.bash from FILESDIR.
Signed-off-by: Kerin Millar <kfm@plushkava.net>
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Signed-off-by: Sam James <sam@gentoo.org>
|
|
This issue was only ever in some 5.3 snapshots. I can't spot which
commit fixed it, but it seems gone now.
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Change was created by running the following command::
ekeyword ^ia64 */*/*.ebuild
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Signed-off-by: Sam James <sam@gentoo.org>
|
|
It can be useful to have snapshots in the pre-release period once
the first alpha is out, as various bugs get reported and fixed from
the alpha, and the next pre-release is usually quite far away.
i.e. if it's worth packaging the alpha, it's worth packaging a followup.
Signed-off-by: Sam James <sam@gentoo.org>
|
|
In bug #934732, Sven Wegener requested for bash to refrain from setting
the "internal" window title. That is, the window title (%t) of GNU
screen and the window_name (#W) of tmux. A patch was attached to the
bug, which I acknowledged and which was subsequently applied by Sven.
Unfortunately - and perhaps owing to my eagerness to have the matter be
resolved - I did not notice that the patch introduces a regression. The
regression is that both screen and tmux are no longer exempted from the
sshd(8) check, resulting in neither the hardstatus (%h) being set for
the former, nor the pane_title (#T) for the latter. This commit restores
the intended behaviour.
In comment #10 of bug #550104, Heui-mun Park makes a compelling case
that the "\033]0;" variant of the Set Text Parameters sequence should be
preferred over other variants. The difference is that it sets the "icon
name" in addition to the "window title". Indeed, I have found that most
applications that employ the sequence make use of this more
comprehensive variant. For many users, such a distinction would amount
to being little more than an artifact of history. Nevertheless, it makes
perfect sense for 10-gentoo-title.bash to be aligned with the practices
of others in this regard. Make it so.
Improve the commentary in 10-gentoo-title.bash, along with the accuracy
and utility of the information conveyed by the ewarn comands in the
ebuilds.
Have the live ebuild (version 9999) install 15-gentoo-bashrc-check.bash,
just as the other recent ebuilds do. It's simpler from a maintenance
standpoint for there to be as few differences between them as is
possible.
Fixes: 9ff9f8199ccf9d55fb1cf066cbbc791101894ab0
Signed-off-by: Kerin Millar <kfm@plushkava.net>
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Stands out more and gets repeated by Portage.
Signed-off-by: Sam James <sam@gentoo.org>
|
|
* Drop shellcheck annotations. We don't use them in ::gentoo right now.
We might revisit that once shellcheck gains proper ebuild support, but right
now, they serve as noise.
* Fix readline version for <5.3_alpha.
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Address a regression whereby the new initialisation files were composing
a PS1 prompt containing '\[' and '\]' for builds without readline
support. These sequences are normally used to denote sequences of
non-printing characters but are not treated specially unless readline
support is present. This came up 12 years ago as bug #432338. SpanKY's
solution at the time was to have the ebuild monkey-patch
/etc/bash/bashrc with sed, disabling colour support outright for the
USE="-readline" case. Unsurprisingly, moving the colour-related code to
a distinct bashrc.d snippet had prevented this method from being
effective.
After deliberating over the matter, I reached the conclusion that there
are already too many ebuilds containing overly brittle code of this
sort. Therefore, I decided to implement a runtime check instead.
Specifically, it is implemented as a trivial function, which works by
checking whether the direxpand shell option exists. This function is now
used in a twofold manner. Firstly, it is used to determine whether the
no_empty_cmd_completion and histappend shell options should be set in
etc/bash/bashrc (both of those require readline). Secondly, it it used
to determine whether the prompt should _not_ be colourised in
/etc/bash/bashrc.d/10-gentoo-color.bash, even in the case that the
terminal is understood to support colour.
Doing it this way has a few immediate benefits. No longer will colour
support be needlessly disabled outright; there was never any sense in
doing that. Instead, users that elect to compile bash without readline -
for whatever reason - may continue to enjoy full colour support with
only the prompt being rendered in monochrome. Moreover, the ebuild has
been simplified as a consequence of being able to completely drop the
section that defined sed_args before proceeding to clumsily modify
/etc/skel/.bashrc (with no effect, mind) and /etc/bash/bashrc.
Render /etc/bash/bashrc.d processing safer by unsetting the GLOBSORT
variable beforehand. This variable, which is introduced by
bash-5.3-alpha, allows for the user to affect the order in which words
occur as a result of pathname expansion. While there is no question that
the feature is useful, it must not be allowed to influence the order in
which files residing under /etc/bash/bashrc.d are processed. That is,
users must be able to expect that the files are processed in an order
that is based solely on the effective collation.
Remove st-256color from the list of terminals whitelisted for colour
support. There was no need for it to be there because it can already be
matched by the *color* globbing pattern.
The latest round of ebuilds have been cleaned up and should be slightly
easier to maintain from hereon. Further, they are now shellcheck-clean,
albeit with two warning categories having been disabled in the global
scope (so chosen because they aren't particularly helpful in the course
of evaluating ebuilds). Finally, version 9999 has been updated so as to
be abreast of these developments.
Signed-off-by: Kerin Millar <kfm@plushkava.net>
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Closes: https://bugs.gentoo.org/928373
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Includes newly-added filter-lto, reported that upstream to Chet. Only in
5.3_alpha as the issue is newly-introduced.
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Signed-off-by: Mike Gilbert <floppym@gentoo.org>
|
|
Signed-off-by: Sam James <sam@gentoo.org>
|
|
if available
-fprofile-partial-training helps not to pessimise other paths if no data
is available.
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Upstream only test with Bison and require GNUisms like YYEOF and
YYERRCODE. The former at least may be in POSIX soon:
https://www.austingroupbugs.net/view.php?id=1269.
configure warns on use of non-Bison but doesn't abort. The result
may misbehave at runtime.
Noticed with recently added bash-5.2_p15-shell-parser-reset-issue.patch
(which is blameless in itself).
A simple test with a broken Bash is:
```
$ /var/tmp/portage/app-shells/bash-5.2_p15-r4/image/bin/bash -n /lib/gentoo/functions.sh
/lib/gentoo/functions.sh: line 104: syntax error near unexpected token `}'
/lib/gentoo/functions.sh: line 104: `}'
```
Reference: 3ee2d707a299f352b6970af459b0c25c356cbb25
Reference: dde3a81f420e745fe884b6535796129192f02561
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Thanks to radhermit's new pkgcraft tooling. Also, thanks to ztrawhcse for suggestions.
Before:
```
app-shells/bash-5.2_p15-r3::.: 61.224122ms
app-shells/bash-5.1_p16-r4::.: 65.001125ms
app-shells/bash-5.1_p16-r5::.: 65.480029ms
```
After:
```
app-shells/bash-5.2_p15-r3::/home/sam/g/: 10.449073ms
app-shells/bash-5.1_p16-r4::/home/sam/g/: 10.505063ms
app-shells/bash-5.1_p16-r5::/home/sam/g/: 10.523583ms
```
This also gets us to approximately the same speed (almost within rounding
error) of pre-d3c19b7974aeb4ac2a1351a019e80625b4111c4b (where we removed eval
usage).
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Closes: https://bugs.gentoo.org/907403
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Signed-off-by: Fabian Groffen <grobian@gentoo.org>
|
|
Signed-off-by: Fabian Groffen <grobian@gentoo.org>
|
|
Signed-off-by: Fabian Groffen <grobian@gentoo.org>
|
|
Signed-off-by: Fabian Groffen <grobian@gentoo.org>
|
|
Signed-off-by: David Seifert <soap@gentoo.org>
|
|
Closes: https://bugs.gentoo.org/896330
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Signed-off-by: Mike Gilbert <floppym@gentoo.org>
|
|
Closes: https://bugs.gentoo.org/889848
Signed-off-by: Leonardo Hernández Hernández <leohdz172@protonmail.com>
Closes: https://github.com/gentoo/gentoo/pull/28985
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Signed-off-by: Leonardo Hernández Hernández <leohdz172@protonmail.com>
Closes: https://github.com/gentoo/gentoo/pull/28659
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Signed-off-by: Sam James <sam@gentoo.org>
|
