diff options
| author | Michael Palimaka <kensington@gentoo.org> | 2016-06-17 05:31:03 +1000 |
|---|---|---|
| committer | Michael Palimaka <kensington@gentoo.org> | 2016-06-17 05:32:35 +1000 |
| commit | 17e1d854dee85c16242babc34e7f925cbed726d3 (patch) | |
| tree | d6b0f3decccd7fd34e0fdf486ebb6a6de0a4c1db | |
| parent | 20ca695b11957840791b832a928a947989f279c8 (diff) | |
| download | kde-17e1d854dee85c16242babc34e7f925cbed726d3.tar.gz kde-17e1d854dee85c16242babc34e7f925cbed726d3.tar.bz2 kde-17e1d854dee85c16242babc34e7f925cbed726d3.zip | |
kde5-functions: die if too many arguments are passed to add_*_dep
This avoids bugs where too many arguments are passed by mistake, causing the
last one to be ignored.
For example, the subslot operator added in d1bc5ac3f0e42df0f0255c8b39d7df16c5d4176b
was never applied because too many '' were passed.
| -rw-r--r-- | eclass/kde5-functions.eclass | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/eclass/kde5-functions.eclass b/eclass/kde5-functions.eclass index b20d406721d..a8cc1a34432 100644 --- a/eclass/kde5-functions.eclass +++ b/eclass/kde5-functions.eclass @@ -141,6 +141,10 @@ _add_category_dep() { add_frameworks_dep() { debug-print-function ${FUNCNAME} "$@" + if [[ $# -gt 4 ]]; then + die "${FUNCNAME} was called with too many arguments" + fi + local version if [[ -n ${3} ]]; then @@ -169,6 +173,10 @@ add_frameworks_dep() { add_plasma_dep() { debug-print-function ${FUNCNAME} "$@" + if [[ $# -gt 4 ]]; then + die "${FUNCNAME} was called with too many arguments" + fi + local version if [[ -n ${3} ]]; then @@ -197,6 +205,10 @@ add_plasma_dep() { add_kdeapps_dep() { debug-print-function ${FUNCNAME} "$@" + if [[ $# -gt 4 ]]; then + die "${FUNCNAME} was called with too many arguments" + fi + local version if [[ -n ${3} ]]; then @@ -230,6 +242,10 @@ add_kdeapps_dep() { add_qt_dep() { debug-print-function ${FUNCNAME} "$@" + if [[ $# -gt 4 ]]; then + die "${FUNCNAME} was called with too many arguments" + fi + local version if [[ -n ${3} ]]; then |