diff options
| author | Sam James <sam@gentoo.org> | 2023-06-26 10:54:06 +0100 |
|---|---|---|
| committer | Andreas Sturmlechner <asturm@gentoo.org> | 2023-09-16 17:03:30 +0200 |
| commit | 2b32cb0d67222da271e2ae25b19479f0374648da (patch) | |
| tree | c71b53372d83c22404c97d610be583e4bfb9d4be /eclass/cmake.eclass | |
| parent | 065572bdc5985f3a481348fb69e0780ee2f7d7ba (diff) | |
| download | kde-2b32cb0d67222da271e2ae25b19479f0374648da.tar.gz kde-2b32cb0d67222da271e2ae25b19479f0374648da.tar.bz2 kde-2b32cb0d67222da271e2ae25b19479f0374648da.zip | |
cmake.eclass: workaround S=${WORKDIR} creating builddir above ${WORKDIR}
When S=${WORKDIR}, cmake.eclass would create its build directory (if CMAKE_USE_DIR
is unset) above WORKDIR(!) as ${WORKDIR}_build. Creating directories above
WORKDIR is not legal.
Portage has its own bug (bug #889418) in that it doesn't clean up unknown directories
above WORKDIR in PORTAGE_TMPDIR, so combined, you get a problem where "ebuild ... clean" doesn't
actually clean things up at all, and you get very confusing issues if e.g. changing
CC between runs.
The explicit S=WORKDIR check isn't truly needed but it makes explicit our
intent here.
Bug: https://bugs.gentoo.org/889418
Closes: https://bugs.gentoo.org/889420
Signed-off-by: Sam James <sam@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Diffstat (limited to 'eclass/cmake.eclass')
| -rw-r--r-- | eclass/cmake.eclass | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/eclass/cmake.eclass b/eclass/cmake.eclass index 340645e917b..91cbf976bba 100644 --- a/eclass/cmake.eclass +++ b/eclass/cmake.eclass @@ -216,6 +216,15 @@ _cmake_check_build_dir() { BUILD_DIR="${CMAKE_USE_DIR}" else : "${BUILD_DIR:=${CMAKE_USE_DIR}_build}" + + # Avoid creating ${WORKDIR}_build (which is above WORKDIR). + # TODO: For EAPI > 8, we should ban S=WORKDIR for CMake. + # See bug #889420. + if [[ ${S} == "${WORKDIR}" && ${BUILD_DIR} == "${WORKDIR}_build" ]] ; then + eqawarn "QA notice: S=WORKDIR is deprecated for cmake.eclass." + eqawarn "Please relocate the sources in src_unpack." + BUILD_DIR="${WORKDIR}"/${P}_build + fi fi einfo "Source directory (CMAKE_USE_DIR): \"${CMAKE_USE_DIR}\"" |