[kde-base/pykde4] Allow clean installation for multiple python versions

1 files changed, 106 insertions, 29 deletions

diff --git a/kde-base/pykde4/pykde4-4.6.49.9999.ebuild b/kde-base/pykde4/pykde4-4.6.49.9999.ebuild
index dc5bcc82601..818e7b7857f 100644
--- a/kde-base/pykde4/pykde4-4.6.49.9999.ebuild
+++ b/kde-base/pykde4/pykde4-4.6.49.9999.ebuild
@@ -4,26 +4,30 @@
 
 EAPI=3
 
-KMNAME="kdebindings"
-if [[ ${PV} != *9999 ]]; then
-	KMMODULE="python/pykde4"
-else
-	# HACK HACK HACK
-	KMMODULE="."
-fi
-OPENGL_REQUIRED="always"
+PYTHON_DEPEND="*:2.5"
+RESTRICT_PYTHON_ABIS="*-jython 2.4"
 PYTHON_USE_WITH="threads"
-RESTRICT_PYTHON_ABIS="2.4"
+SUPPORT_PYTHON_ABIS="1"
+
+OPENGL_REQUIRED="always"
 KDE_SCM="git"
-EGIT_REPONAME="pykde4"
-inherit python kde4-meta
+if [[ ${PV} == *9999 ]]; then
+	KMMODULE="."
+	kde_eclass="kde4-base"
+else
+	KMNAME="kdebindings"
+	KMMODULE="python/pykde4"
+	kde_eclass="kde4-meta"
+fi
+
+inherit python portability ${kde_eclass}
 
 DESCRIPTION="Python bindings for KDE4"
 KEYWORDS=""
 IUSE="debug doc examples semantic-desktop"
 
 # blocker added due to compatibility issues and error during compile time
-DEPEND="
+RDEPEND="
 	!dev-python/pykde
 	>=dev-python/sip-4.12
 	$(add_kdebase_dep kdelibs 'opengl,semantic-desktop=')
@@ -31,17 +35,34 @@ DEPEND="
 	aqua? ( >=dev-python/PyQt4-4.8.2[dbus,declarative,sql,svg,webkit,aqua] )
 	!aqua? ( >=dev-python/PyQt4-4.8.2[dbus,declarative,sql,svg,webkit,X] )
 "
-RDEPEND="${DEPEND}"
+DEPEND="${RDEPEND}
+	sys-devel/libtool
+"
 
-PATCHES=( "${FILESDIR}/${PN}-4.6.4-pyqt475.patch" )
+PATCHES=(
+	"${FILESDIR}"/${PN}-4.6.4-pyqt475.patch
+	"${FILESDIR}"/${PN}-4.6.3-python-3.2.patch
+)
 
 pkg_setup() {
 	python_pkg_setup
-	kde4-meta_pkg_setup
+	${kde_eclass}_pkg_setup
+
+	have_python2=false
+
+	scan_python_versions() {
+		[[ ${PYTHON_ABI} == 2.* ]] && have_python2=true
+		:
+	}
+	python_execute_function -q scan_python_versions
+	if ! ${have_python2}; then
+		ewarn "You do not have a Python 2 version selected."
+		ewarn "kpythonpluginfactory will not be built"
+	fi
 }
 
 src_prepare() {
-	kde4-meta_src_prepare
+	${kde_eclass}_src_prepare
 
 	if ! use examples; then
 		sed -e '/^ADD_SUBDIRECTORY(examples)/s/^/# DISABLED /' -i ${KMMODULE}/CMakeLists.txt \
@@ -50,33 +71,89 @@ src_prepare() {
 
 	# See bug 322351
 	use arm && epatch "${FILESDIR}/${PN}-4.4.4-arm-sip.patch"
+
+	sed -i -e 's/kpythonpluginfactory /kpython${PYTHON_SHORT_VERSION}pluginfactory /g' ${KMMODULE}/kpythonpluginfactory/CMakeLists.txt
+
+	if ${have_python2}; then
+		mkdir -p "${WORKDIR}/wrapper" || die "failed to copy wrapper"
+		cp "${FILESDIR}/kpythonpluginfactorywrapper.c" "${WORKDIR}/wrapper" || die "failed to copy wrapper"
+	fi
 }
 
 src_configure() {
 	# Required for KTabWidget::label
 	append-cxxflags -DKDE3_SUPPORT
 
-	mycmakeargs=(
-		-DWITH_PolkitQt=OFF
-		-DWITH_QScintilla=OFF
-		$(cmake-utils_use_with semantic-desktop Soprano)
-		$(cmake-utils_use_with semantic-desktop Nepomuk)
-		$(cmake-utils_use_with semantic-desktop KdepimLibs)
-	)
+	configuration() {
+		local mycmakeargs=(
+			-DWITH_PolkitQt=OFF
+			-DWITH_QScintilla=OFF
+			$(cmake-utils_use_with semantic-desktop Soprano)
+			$(cmake-utils_use_with semantic-desktop Nepomuk)
+			$(cmake-utils_use_with semantic-desktop KdepimLibs)
+			-DPYTHON_EXECUTABLE=$(PYTHON -a)
+		)
+		local CMAKE_BUILD_DIR=${S}_build-${PYTHON_ABI}
+		${kde_eclass}_src_configure
+	}
+
+	python_execute_function configuration
+}
+
+echo_and_run() {
+	echo "$@"
+	"$@"
+}
 
-	kde4-meta_src_configure
+src_compile() {
+	compilation() {
+		local CMAKE_BUILD_DIR=${S}_build-${PYTHON_ABI}
+		${kde_eclass}_src_compile
+	}
+	python_execute_function compilation
+
+	if ${have_python2}; then
+		cd "${WORKDIR}/wrapper"
+		echo_and_run libtool --tag=CC --mode=compile $(tc-getCC) \
+			-shared \
+			${CFLAGS} ${CPPFLAGS} \
+			-DEPREFIX="\"${EPREFIX}\"" \
+			-DPLUGIN_DIR="\"/usr/$(get_libdir)/kde4\"" -c \
+			-o kpythonpluginfactorywrapper.lo \
+			kpythonpluginfactorywrapper.c
+		echo_and_run libtool --tag=CC --mode=link $(tc-getCC) \
+			-shared -module -avoid-version \
+			${CFLAGS} ${LDFLAGS} \
+			-o kpythonpluginfactory.la \
+			-rpath "${EPREFIX}/usr/$(get_libdir)/kde4" \
+			kpythonpluginfactorywrapper.lo \
+			$(dlopen_lib)
+	fi
 }
 
 src_install() {
-	use doc && HTML_DOCS=("${S}/${KMMODULE}/docs/html/")
+	installation() {
+		cd "${S}_build-${PYTHON_ABI}"
+		emake DESTDIR="${T}/images/${PYTHON_ABI}" install || die "emake install failed for Python ${PYTHON_ABI}"
+	}
+	python_execute_function installation
 
-	kde4-meta_src_install
+	python_merge_intermediate_installation_images "${T}/images/${PYTHON_ABI}"
 
-	python_convert_shebangs -q -r $(python_get_version) "${ED}"
+	# As we don't call the eclass's src_install, we have to install the docs manually
+	DOCS=("${S}"/${KMMODULE}/{AUTHORS,NEWS,README})
+	use doc && HTML_DOCS=("${S}/${KMMODULE}/docs/html/")
+	base_src_install_docs
+
+	if ${have_python2}; then
+		cd "${WORKDIR}/wrapper"
+		echo_and_run libtool --mode=install install kpythonpluginfactory.la "${ED}/usr/$(get_libdir)/kde4/kpythonpluginfactory.la"
+		rm "${ED}/usr/$(get_libdir)/kde4/kpythonpluginfactory.la"
+	fi
 }
 
 pkg_postinst() {
-	kde4-meta_pkg_postinst
+	${kde_eclass}_pkg_postinst
 
 	python_mod_optimize PyKDE4 PyQt4/uic/pykdeuic4.py PyQt4/uic/widget-plugins/kde4.py
 
@@ -89,7 +166,7 @@ pkg_postinst() {
 }
 
 pkg_postrm() {
-	kde4-meta_pkg_postrm
+	${kde_eclass}_pkg_postrm
 
 	python_mod_cleanup PyKDE4 PyQt4/uic/pykdeuic4.py PyQt4/uic/widget-plugins/kde4.py
 }